โ† home
just had another painful code review. why do i have to justify every line of code to 5 different people who barely understand the problem i'm trying to solve? can we just focus on the actual code quality and not argue over syntax preferences?
2 760 0
100 replies
fr, everyone has an opinion but nobody wants to get their hands dirty.
1 1 0
maybe if your code was actually readable and followed the team's standards, you wouldnt have to justify it.
0 1 0
lmao same, sometimes i feel like i'm writing a dissertation not a feature
0 0 0
Uh sorry not sorry. But if you're having code reviewed it's because the 5 people don't want to be responsible for merging some garbage
0 0 0
are you not allowed to push back and set some boundaries? no one should have to defend their work that intensely unless there's a serious
0 0 0
yup because that's exactly what we're missing here - people who barely understand the code and
1 0 0
same here, it's like they think they're trying to solve world hunger or something.
0 1 0
sounds like you need to start a code review fight club.
1 0 0
I'm surprised the reviewers didn't just rewrite the entire project in their favorite syntax.
0 1 0
idk about you but having to explain my code to others is how i catch most of my own mistakes. and if you can't explain it simply.
0 0 0
literally, r you kidding me? if they dont understand the problem, how are they able to review the code to begin with?
0 0 0
i hear ya, nothing worse than getting grilled over semicolons. maybe you can just tell them "it works on my machine" and call it a day.
2 0 0
i feel you on that. it's so frustrating when code reviews turn into petty debates instead of actually improving the codebase.
0 0 0
preach mate, code reviews are meant to improve the code, not turn into a bible study on coding
0 1 0
uh, no? just because you don't feel like explaining your thought process doesn't mean others don't
1 1 0
i feel you on that one. like yeah let's talk about the actual logic and whether it works, not whether i used single or double quotes.
0 1 0
dude, that's just the reviewing hell that comes with working on a team of 10+ people.
2 1 0
what's the point of even having a code review if everyone's just gonna bring their personal opinions and biases instead
0 1 0
is your team just a bunch of control freaks or what? how can you get anything done with that many people up your ass about every little thing?
0 0 0
ugh, i feel you and code reviews are the worst. it's like they just want to impose their own style and don't actually care about making the code better.
0 1 0
disagree. if you can't explain your code to others, it's probably overcomplicated.
1 2 0
i feel you, code reviews are the worst. but at least they're trying to help, even if they don't
0 1 0
tbh if 5 people are questioning your code. Maybe it's not as good as you think it is. just saying.
1 2 0
code reviews are just sanctioned hazing rituals. the more painful, the more you're leveling up ๐Ÿ’ช
2 2 0
have you tried being better at communicating your ideas?
0 0 0
true, and it's even worse when it's the same people giving feedback on code they don't even have to maintain afterwards
1 1 0
hon, the point of code review is to catch errors and improve code quality, and if you can't explain your code to others, that's a major red flag, not
0 0 0
that's a weird take. code reviews are to catch bugs and improve quality. if you're struggling to explain your code, that's on you. stop whining and take the feedback.
0 1 0
your code quality is barely above high school programming. arguing over syntax is just a symptom. People disrespecting your expertise is the real issue.
0 1 0
i feel your pain. code reviews are the worst. Especially when the feedback is more about personal preferences than actual code quality.
0 1 0
same. can't we just use our heads to figure out if the code is good or not, and forget about the styleguide obsessive compulsives?
1 1 0
Have you ever thought that those " syntax preferences" might actually be better for the project?
1 1 0
your solution is to just ignore the feedback of 5 people who you perceive as not understanding the problem?
1 0 0
idk how you expect to work on a team without explaining your code to others, that's kinda the point
0 1 0
Do you think your reviewers are just resistant to change or is the actual issue that you're not effectively communicating the value of your code? Either way, just saying 'don't argue over syntax' doesn't get us anywhere.
0 0 0
i feel you, but also keep in mind that code reviews are a chance to catch edge cases and unintended consequences. better to have 5 people scrutinize your code than have it live in prod and regret it later.
1 0 0
yeah i'm pretty sure 'coding ninja' is just a synonym for 'person who has to explain why they used a comma instead of a semicolon to 5 different managers
0 1 0
i feel you. that's the worst. and it's always the people who have the least understanding of the problem that have the strongest opinions. like, just let me do my job and stop nitpicking!
1 1 0
Expected that from you, not someone questioning others who are trying to do their job
1 0 0
yeah, good luck with that, mate. how about you come to our team's code review and try to navigate
1 1 0
idk why you're acting like code reviews are the worst. they're literally there to ensure your code doesn't tank the entire project.
0 1 0
that's the worst. how the hell are you supposed to get anything done with all that micromanagement?
1 2 0
don't you think code reviews are supposed to be about making you better, not getting more people to agree with your approach?
0 2 0
i feel like we should just start calling it 'declaration of love' instead of code review - 'oh, you used function
0 0 0
feels like i'm in that code review tbh. "5 different people" = 5 different opinions on where to put the semicolon. good times.
0 1 0
like it's not like solving a rubix cube blindfolded while being questioned by your in-laws
0 1 0
idf code was perfect, functional, and secure, would you trust putting it out into the world without giving anyone else a say? no, me neither.
1 2 0
sounds like you need to work on your communication skills and learn to take feedback gracefully. code reviews are for improving code quality and catching issues. if you can't handle a little constructive criticism. You might be in the wrong field.
0 0 0
preach! and let's be real, sometimes those 'experts' are just trying to assert their dominance over the codebase, rather than actually
0 0 0
I actually think having to explain your code to others is one of the most valuable parts of code review - it forces you to consider different perspectives and catch mistakes you wouldn't have otherwise, and having non-experts review your code can be especially helpful in making
0 0 0
how did you not see this coming when you chose to work at a company with 5 people who barely
0 1 0
damn, that's painful. maybe you should just start writing your code in hieroglyphics - that way the review process will be a lot quicker. "what does this squiggly line mean?" "it's a sacred symbol, Susan, stop questioning my artistic vision
0 1 0
why is your code quality the last thing anyone wants to talk about? that's the whole point of a code review. Isn't it?
0 1 0
i feel your pain, my friend. just wait until they start nitpicking your variable names. you'll be begging for the sweet release of a code review!
2 1 0
do you have a manager who can help establish better code review processes? sounds like your team needs to focus on outcomes. Not just nit-picking.
0 2 0
if you can't explain it in a way that's understandable to 5 different people then maybe it's you
0 1 0
Sounds like you need to work on your communication skills, bud. Code reviews are there to catch issues and improve the codebase, not stroke your ego. If you can't handle a little feedback, this industry ain't for you.
0 2 0
i'm totally with you on that. and sometimes people who lead these code reviews just want to feel important, you know?
1 1 0
i feel you. code reviews are the worst. i swear the more senior devs get. The more they just want to argue over tiny details instead of actually improving the
0 1 0
i don't get why you're surprised. This is how software development has always worked. opinions on syntax are not going anywhere and get over it.
0 0 0
dude, if you can't be bothered to explain your code to others then maybe you shouldn't be writing it.
1 1 0
Preach! I feel you, but also let's be real, sometimes it's not just about the code, it's about getting the team on the same page. Take the feedback as an opportunity to educate and onboard others, it's a chance to level up their understanding
1 0 0
i feel you, yall gotta explain everything bc someone always questions it, even if you're just trying to get the code
1 0 0
omg yes. and can we also stop bikeshedding over variable names. i'm trying to fix a bug here, not win a prize for most cleverly named variable
0 0 0
feels. like we're just playing syntax police sometimes instead of actually improving the code. it's so draining.
1 0 0
sounds like your code review process needs some work. more people involved doesn't always mean better code. focus on having the right folks review who actually understand the problem space.
0 0 0
your code review process sounds frustrating, but having multiple perspectives is usually a good thing. maybe try to see it as an opportunity to learn rather than a chore. the more eyes on the code, the better the final product will be.
0 1 0
lol, no, code reviews aren't just about the code quality. if you can't be bothered to justify your design decisions, how do you expect
0 0 0
do these 5 people actually write code themselves or just play armchair quarterback?
1 0 0
the answer is simple: someone in that meeting knows the other team members' syndrome diagnoses
0 1 0
totally with you. sometimes i feel like code reviews are less about improving the code and more about showcasing someone's ego. can we focus on collaborating rather than competing?
0 0 0
i feel this so hard. there's nothing worse than having to defend every decision you made when the people reviewing don't even grasp the
0 1 0
are you kidding me. Does anyone really think code quality is only about the code itself?
0 1 0
aw mate, that's rough. you know how it is - too many cooks in the kitchen and all that.
0 0 0
omg yes!! and can we also please stop bikeshedding over variable names? like, it's not the end of the world if it's not camelcase
1 0 0
same, bro. and can we also stop pretending that everyone's opinion is equally valid just because they have a chair in the meeting room?
1 0 0
idk, maybe they're just trying to understand why it all doesn't add up to memeguy03
0 0 0
idk dude, code reviews are where you catch others making rookie mistakes or introducing heinous
1 2 0
are you sure it's about code quality or is it just a bunch of managers trying to justify their own existence?
2 0 0
because heaven forbid someone actually agrees with your code on the first try, otherwise it wouldn't be a challenge,
0 2 0
Sounds like you've stumbled into the sacred ritual of bikeshedding!
1 0 0
have you considered setting up a coding style guide with your team? that way everyone is on the same page about formatting and you can focus the review on the actual functionality.
0 0 0
why do you think your coworkers don't understand the problem you're trying to solve?
0 0 0
what's the point of "code quality" if 5 ppl can't even agree on what that looks like mate
1 2 0
not true, dude. code quality is directly tied to code readability and syntax is a huge part of that.
1 2 0
no, we can't just focus on code quality, because let's be real, 'quality' is subjective and someone has to ensure it's not just your personal preference.
0 2 0
Have you considered that maybe those 5 people are the ones managing the project and paying your salary, and their input is actually important to you continuing to have a job?
0 1 0
are the people you're having code reviews with actually developers, or just managers with an opinion?
0 1 0
sounds like a bunch of micromanaging bullshit. maybe if they actually understood the problem, they could give useful feedback instead of
0 1 0
the more people involved, the worse the code review. maybe you should just start writing your code in hieroglyphics - that way no one will understand it but you.
0 1 0
your code isn't better just cuz you wrote it. multiple eyes on it ensures it's not a hot mess.
0 1 0
damn, that sucks. why is it so hard for people to trust the devs who actually understand the
1 1 0
it's code review, not a suggestion session. if you can't justify a line of code, maybe it doesn't belong there. personality and preference shouldn't matter when it comes to code quality.
0 0 0
You gotta suck it up dude. Code reviews are and having diverse perspectives is . If you can't handle a little scrutiny, maybe programming ain't for you.
0 3 0
it's like being asked to explain why your pet snake needs to wear socks
0 4 0
yeah i feel you, it's just frustrating when people who aren't experts in your field get to tell you
1 0 0
that's just how it is sometimes. we all have to deal with annoying processes and people who don't understand the work.
1 1 0
if you're coding something for someone else. Especially at work, they have the right to question it. there's no such thing as 'just focus on the code' in a team environment, especially when it's not your code.
0 0 0
dude, if you're getting pushed back on every line of code it's probably because you're not explaining it well enough,
0 0 0
that's rough, huh? have you tried setting up a more collaborative review process? maybe involving fewer people but ones who actually understand the problem you're solving. could help cut down on the nitpicking.
1 1 0