I'm starting to think that code reviews are just a way for our team's more senior engineers to explain why their own code from 5 years ago is still the best way to do things.
That's a really unfair stereotype and it's not true for our team. Code reviews are meant to be a collaborative way to learn and improve our processes, not about old people being
Hah, sounds like someone's feeling a little defensive about their legacy code! ๐ค Code reviews are just a friendly way for us to bond over shared tech debt - the true meaning of
been on both sides of this argument, and im convinced code reviews are for catching mistakes and ensuring knowledge sharing, not ego trips. if your team's seniors are using reviews to stroke their egos, thats a people problem not a process problem
nah, code reviews aren't about stroking egos, they're about keeping the codebase from turning into a mess. if a 5 year old solution still holds up, great, but that's not the point. the point is to discuss and improve, not to prove who's right
thats a terrible take. code reviews are about improving the codebase, not stroking egos. if you're seeing that on your team then you have bigger problems to address.
Yup, that's a thing. But it's also a chance for us to own our shared codebase and make intentional decisions about how we want to evolve our tech debt, rather than just preserving the status quo.
Do you have specific examples of that happening, or is this just a general feeling? I'd be interested to hear more about your experiences with code reviews if you're willing to
wow, that's a pretty cynical take. is that really what you think the purpose of code reviews is? i'd be curious to hear more about your experiences that have led you to that conclusion.
Haha, do you have any specific examples of that? I'm curious to hear more about the code review process on your team and where you think it could be improved.
That's not what code reviews are for. They're about ensuring the code we write today is quality, maintainable, and scalable for the projects we're working on now, not defending ancient codebases.
yeah this is my experience too, it's like they're using code reviews to revive their own past work rather than actually improving the product or helping the team. it's a missed opportunity to share knowledge and drive growth.
lmao so true. and at the same time it's also a chance for the more senior engineers to actually learn from the newer approaches and be humble enough to update their own code, that's what separates a leader from someone just holding on to ego
Preach. And let's be real, a lot of the time it's not even about being right, it's about being heard. If you're not actively writing new code, you're probably not improving.
Couldn't agree more. It feels like code reviews often devolve into nostalgia sessions rather than actual productive feedback, making it hard to keep learning and improving.
totally with you on this. it's also a way to check if the newer dev can be challenged and will assume their new idea is valid enough to warrant a rewrite of the old code.
No way man, code reviews are . Just because some folks can't let go of their old ways doesn't mean the whole process is useless. It's about quality. Consistency, and making sure we're all on the same page. Some people just need to get with the times.
well actually, there's some truth to that. code reviews can sometimes turn into a lesson on "the way things used to be" rather than constructive feedback. it's important to strike a balance between institutional knowledge and embracing new approaches.
Code reviews are exactly that - an opportunity for everyone to learn from each other, not just about code from 5 years ago, but about what we can improve and do better today.
couldn't agree more - it's like, code doesn't get better with age just because you wrote it. and can we also talk about how often it's just a power trip?